Feat/xread maxcount maxsize#3335
Open
nkaradzhov wants to merge 2 commits into
Open
Conversation
Redis 8.10 adds cumulative reply caps across all streams in XREAD and XREADGROUP. Unlike COUNT (per-stream), MAXCOUNT caps the total number of entries and MAXSIZE soft-caps the total reply size in bytes across all stream keys. Both are exposed as optional numeric fields on the existing options objects and emitted as uppercase tokens in canonical order before STREAMS, omitted when unset. Purely additive: response shape, blocking, consumer-group, and stream-id semantics are unchanged and the existing Streams reply parser is reused. No client-side validation is added, so server errors propagate as-is. Options are since 8.10.0. The XREADGROUP option push order was aligned to the canonical order (COUNT MAXCOUNT MAXSIZE BLOCK CLAIM NOACK). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add cumulative MAXSIZE cap integration tests for XREAD and XREADGROUP (MAXSIZE 1 over two streams returns exactly one entry, matching the server's global soft-cap semantics), gated to Redis 8.10+. Fix XREAD to guard COUNT with `\!== undefined` instead of a truthy check, so `COUNT: 0` is forwarded consistently with MAXCOUNT/MAXSIZE/BLOCK and with XREADGROUP. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
PavelPashov
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redis 8.10 adds cumulative reply caps across all streams in XREAD and
XREADGROUP. Unlike COUNT (per-stream), MAXCOUNT caps the total number of
entries and MAXSIZE soft-caps the total reply size in bytes across all
stream keys.
Both are exposed as optional numeric fields on the existing options
objects and emitted as uppercase tokens in canonical order before
STREAMS, omitted when unset. Purely additive: response shape, blocking,
consumer-group, and stream-id semantics are unchanged and the existing
Streams reply parser is reused. No client-side validation is added, so
server errors propagate as-is. Options are since 8.10.0.
The XREADGROUP option push order was aligned to the canonical order
(COUNT MAXCOUNT MAXSIZE BLOCK CLAIM NOACK).
Fix XREAD to guard COUNT with
\!== undefinedinstead of a truthy check,so
COUNT: 0is forwarded consistently with MAXCOUNT/MAXSIZE/BLOCK andwith XREADGROUP.